Update LibUsbDotNet to latest version#39
Open
MicBoucinha wants to merge 3 commits intoharp-tech:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this PR updates LibUsbDotNet to the latest available version (3.0.167-alpha).
Although this is an alpha version, there seems to be a consensus that it is in a state that will be released a final version soon (please see LibUsbDotNet/LibUsbDotNet#266).
The main advantage of this PR is that this version bundles the native libusb DLLs for the different platforms and architectures. This is important for bundled .app macOS applications that use libusb, since they aren't able to find correctly the native DLL due to restrictions with SIP.
Some necessary changes were needed to the project, mainly the addition of net8.0 as a TargetFramework and some API changes on how to handle the connection.
This PR also fixes an issue on Linux, where this was setting the Configuration for the device, even if that Configuration was already set. According to libusb's documentation (here: https://libusb.sourceforge.io/api-1.0/group__libusb__dev.html#ga785ddea63a2b9bcb879a614ca4867bed), on this occasion, the call to the method acts as a reset, which was preventing subsequent usage of UpdateWaveform.