harsh/optimizations/embeddings#61
Merged
harshkedia177 merged 2 commits intomainfrom Mar 25, 2026
Merged
Conversation
Owner
harshkedia177
commented
Mar 25, 2026
harshkedia177
commented
- refactor: optimize embedding process and enhance pipeline logging
- feat(embeddings): add dimension validation to NodeEmbedding
- Introduced a new `_embed_node_list` function to streamline the embedding of graph nodes, improving code reusability. - Updated the `embed_graph` and `embed_nodes` functions to utilize the new embedding method, enhancing clarity and maintainability. - Increased the default batch size for embeddings from 64 to 256 for improved performance. - Added logging to track the timing of various phases in the pipeline, providing better insights into processing durations. - Cleaned up the Kuzu backend to manage embeddings more efficiently, including a mechanism to wipe the embeddings table before bulk loading. - Adjusted tests to reflect changes in embedding parameters and batch sizes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.