Enable additional volume mounts and ports by default#16
Enable additional volume mounts and ports by default#16jbarlow-mcafee wants to merge 1 commit intoharvard-itsecurity:masterfrom
Conversation
This commit exposes volume mounts by default for the MISP and SSL cert/key directories. This commit also exposes ports for external configuration, including the web server (80 and 443), mysql (3306), redis (6379), and MISP ZeroMQ (50000).
| sudo -u www-data cp -a /var/www/MISP/app/Config/core.default.php /var/www/MISP/app/Config/core.php ; \ | ||
| sudo -u www-data cp -a /var/www/MISP/app/Config/config.default.php /var/www/MISP/app/Config/config.php | ||
|
|
||
| VOLUME /var/www/MISP/app/Config |
There was a problem hiding this comment.
I had to move this from where it was previously because otherwise the git clone into the /var/www/MISP directory earlier would fail because the directory was non-empty. Maybe there's a better way to do this though?
There was a problem hiding this comment.
The only problem here is that per Docker the way volume mounts work is that if you make any changes after declaring them - those changes are lost.
Specifically:
"if any build steps change the data within the volume after it has been declared, those changes will be discarded."
This basically summarizes as having to declare Volumes "up above" before anything actually utilizes them/makes changes to them.
There was a problem hiding this comment.
@jbarlow-mcafee ^ Just pinging about this in case it was lost among the emails from the pull request/merges/etc.
There was a problem hiding this comment.
@ventz Ah, sorry. I apparently missed the e-mail notifications for your responses. I agree that the order for the volume mounts would be a problem with the changes as I have them here. I've been working on a separate idea for how these volumes could be mounted by default. As these changes would be more extensive than what I have here, I'll put up a separate PR with those and just close this one out for now. Thanks again!
There was a problem hiding this comment.
I put up #17 as a replacement for this PR.
2 participants
This commit exposes volume mounts by default for the MISP and SSL
cert/key directories.
This commit also exposes ports for external configuration, including the
web server (80 and 443), mysql (3306), redis (6379), and MISP ZeroMQ
(50000).
The purpose of the commit would just be to make it easier for users to
be to see the available ports and volumes at container creation time in
GUI tools like Kitematic or Docker Cloud without having to do any
customization of the Dockerfile or with docker commands on
the command line.
Thanks for considering this!