Added more pooling layers to torch_nn.py#30
Open
suzgunmirac wants to merge 2 commits intoharvardnlp:masterfrom
Open
Added more pooling layers to torch_nn.py#30suzgunmirac wants to merge 2 commits intoharvardnlp:masterfrom
suzgunmirac wants to merge 2 commits intoharvardnlp:masterfrom
Conversation
Contributor
|
Looks great, but lint tests are failing. Be sure to run format.sh first. |
Contributor
|
Also be careful. MaxUnpool needs to indices, so it is not going to work. |
Contributor
|
Changed around the nn style a bit. maybe we can update avg pool to the new style. (honestly though we won't use any of these this assignment, they're more for images) |
Contributor
Author
|
Thank you so much for the update, Professor Rush! In this case, I will update the pooling layers once we finalize the nn style. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I realized that six of the pooling layers in torch.nn were initially missing, so I added them to torch_nn.py.