Skip to content

feat: align scanner with codex marketplace spec#36

Merged
kantorcodes merged 2 commits intomainfrom
feat/codex-spec-alignment-v2
Apr 3, 2026
Merged

feat: align scanner with codex marketplace spec#36
kantorcodes merged 2 commits intomainfrom
feat/codex-spec-alignment-v2

Conversation

@kantorcodes
Copy link
Copy Markdown
Member

@kantorcodes kantorcodes commented Apr 3, 2026

Summary

  • add a scoped v2 PRD and implementation todo for Codex spec alignment
  • align marketplace and manifest validation with current Codex conventions, including ./ path semantics and .agents/plugins/marketplace.json
  • harden MCP verify/doctor flows and extend the GitHub Action with direct SARIF upload plus policy/verification outputs

Verification

  • ruff check .
  • ruff format --check .
  • python -m pytest -q
  • python -m build

Signed-off-by: Michael Kantor <6068672+kantorcodes@users.noreply.github.com>
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aligns the scanner with the v2 Codex specification, focusing on marketplace manifest discovery, path normalization, and hardened MCP runtime verification. Key changes include support for the .agents/plugins/marketplace.json location, ensuring relative paths use the ./ prefix, and implementing a full JSON-RPC handshake for MCP stdio servers. Additionally, the GitHub Action now supports automatic SARIF uploads and provides new outputs for policy and verification status. Feedback suggests addressing a blocking readline call in the MCP handshake, synchronizing a hardcoded version string with the package version, and simplifying process cleanup logic.

Signed-off-by: Michael Kantor <6068672+kantorcodes@users.noreply.github.com>
@kantorcodes kantorcodes merged commit eaab8a0 into main Apr 3, 2026
19 of 20 checks passed
kantorcodes added a commit that referenced this pull request Apr 3, 2026
* feat: align scanner with codex marketplace spec

Signed-off-by: Michael Kantor <6068672+kantorcodes@users.noreply.github.com>

* fix: harden mcp handshake reads

Signed-off-by: Michael Kantor <6068672+kantorcodes@users.noreply.github.com>

---------

Signed-off-by: Michael Kantor <6068672+kantorcodes@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant