Skip to content

fix: restore publishable cisco extra metadata#42

Merged
kantorcodes merged 2 commits intomainfrom
feat/fix-pypi-publish-attestations
Apr 4, 2026
Merged

fix: restore publishable cisco extra metadata#42
kantorcodes merged 2 commits intomainfrom
feat/fix-pypi-publish-attestations

Conversation

@kantorcodes
Copy link
Copy Markdown
Member

@kantorcodes kantorcodes commented Apr 4, 2026

Summary

  • replace the Cisco extra's direct Git dependency with the published cisco-ai-skill-scanner==2.0.7 package
  • align the Marketplace action install path and docs with the publishable PyPI contract
  • regenerate uv.lock and keep the Cisco-enabled scan path covered by the existing action-bundle regression checks

Verification

  • uv sync --frozen --extra dev --extra cisco --group publish
  • ./.venv/bin/ruff check .
  • ./.venv/bin/pytest -q
  • ./.venv/bin/python -m build
  • ./.venv/bin/python -m twine check dist/*
  • ./.venv/bin/codex-plugin-scanner scan tests/fixtures/good-plugin --format json --cisco-skill-scan on --cisco-policy balanced
  • inspected the built wheel metadata to confirm Requires-Dist now contains cisco-ai-skill-scanner==2.0.7 instead of a direct Git URL

Signed-off-by: Michael Kantor <6068672+kantorcodes@users.noreply.github.com>
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the cisco-ai-skill-scanner dependency from a git-based fork to a stable version (2.0.7) from PyPI and performs a minor downgrade of litellm to version 1.82.3. The reviewer suggested improving maintainability by dynamically extracting the cisco-ai-skill-scanner version from pyproject.toml within the GitHub Action, rather than hardcoding it, and provided corresponding updates for the test suite.

Signed-off-by: Michael Kantor <6068672+kantorcodes@users.noreply.github.com>
@kilo-code-bot
Copy link
Copy Markdown

kilo-code-bot bot commented Apr 4, 2026

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (6 files)
  • README.md - Documentation updates
  • action/README.md - Documentation updates
  • action/action.yml - Install logic refactored to use pip extras
  • pyproject.toml - Cisco dependency changed from git ref to PyPI package
  • tests/test_action_bundle.py - Tests updated for new install pattern
  • uv.lock - Regenerated lock file

Reviewed by minimax-m2.5-20260211 · 118,507 tokens

@kantorcodes kantorcodes merged commit 6e62149 into main Apr 4, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant