Open
Conversation
Update tests to create 2 GCP instances with different filters to test out discovering GCP instances by filter
elimt
changed the title
johanbrandhorst
previously approved these changes
Jan 6, 2025
moduli
reviewed
Jan 6, 2025
testing/internal/e2e/tests/gcp/dynamichostcatalog_host_set_test.go
Outdated
Show resolved
Hide resolved
moduli
reviewed
Jan 7, 2025
Comment on lines
+257
to
+258
| var targetIps []string | ||
| err = json.Unmarshal([]byte(c.GcpHostSetIps1), &targetIps) |
Collaborator
There was a problem hiding this comment.
Just realized, is this being used anywhere?
EDIT: Wait, should all of these expected values be set tot he length of targetIps?
Contributor
Author
There was a problem hiding this comment.
Actually, I have to take that out because it's not being used
For your second comment, the targetIps are 2. The private IP and the public IP.
When we create a host set with a specific filter that matches Target 1 in this example, only 1 host catalog is created with 2 IP addresses so only 1 HostId will be returned. The assertion only checks for 1 host catalog returned
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update tests to create 2 GCP instances with different filters to test out discovering GCP instances by filter