Skip to content

Conversation

@zamoore
Copy link
Contributor

@zamoore zamoore commented Jul 22, 2025

πŸ“Œ Summary

If merged, this PR will change ember-math-helpers from a devDependency to a dependency.

This fixes bugs when users do not have ember-math-helpers installed.

πŸ› οΈ Detailed description

ember-math-helpers was added as a dependency in the 4.21 release as part of the AdvancedTable work, but it was added to the wrong dependency list.


πŸ‘€ Component checklist

πŸ’¬ Please consider using conventional comments when reviewing this PR.

πŸ“‹ PCI review checklist
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've worked with GRC to document the impact of any changes to security controls.
    Examples of changes to controls include access controls, encryption, logging, etc.
  • If applicable, I've worked with GRC to ensure compliance due to a significant change to the in-scope PCI environment.
    Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.

@zamoore zamoore requested a review from a team as a code owner July 22, 2025 18:00
@vercel
Copy link

vercel bot commented Jul 22, 2025

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated (UTC)
hds-showcase βœ… Ready (Inspect) Visit Preview Jul 22, 2025 8:26pm
hds-website βœ… Ready (Inspect) Visit Preview Jul 22, 2025 8:26pm

didoo
didoo previously approved these changes Jul 22, 2025
Co-authored-by: Dylan Hyun <dylan.hyun@hashicorp.com>
dchyun
dchyun previously approved these changes Jul 22, 2025
@aklkv
Copy link
Collaborator

aklkv commented Jul 22, 2025

can we hold of on mergin this I would like to address a couple of issues with this dep https://github.com/RobbieTheWagner/ember-math-helpers/blob/main/ember-math-helpers/package.json#L90 it's mainly this RobbieTheWagner/ember-math-helpers#2145

@RobbieTheWagner being an owner will help me with that, I will try to get new version out pretty quick

@zamoore
Copy link
Contributor Author

zamoore commented Jul 22, 2025

can we hold of on mergin this I would like to address a couple of issues with this dep https://github.com/RobbieTheWagner/ember-math-helpers/blob/main/ember-math-helpers/package.json#L90 it's mainly this RobbieTheWagner/ember-math-helpers#2145

@RobbieTheWagner being an owner will help me with that, I will try to get new version out pretty quick

That's probably fine. We want to release a patch change asap, but if you think you can get this merged today/tomorrow, we can hold off. Otherwise, we're doing another minor release in a week and half where we could update the dep again. Just let me know.

Thanks for checking out the change.

@aklkv
Copy link
Collaborator

aklkv commented Jul 22, 2025

I will work on this today, but side note base line support for this addon is 4.12 just something to be aware

@aklkv
Copy link
Collaborator

aklkv commented Jul 23, 2025

Well I think I spoke too soon, I am now locked out from my mac. I wouldn't want to hold up this PR from to long, unless @RobbieTheWagner can merge linked PR and release new version, you can proceed with merging this PR as is, and I will make sure to follow up

@zamoore
Copy link
Contributor Author

zamoore commented Jul 23, 2025

Closing in favor of #3043

@zamoore zamoore closed this Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants