-
Notifications
You must be signed in to change notification settings - Fork 50
Move ember-math-helpers from devDependency to dependency
#3039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
9d418b2 to
7f8d360
Compare
Co-authored-by: Dylan Hyun <dylan.hyun@hashicorp.com>
|
can we hold of on mergin this I would like to address a couple of issues with this dep https://github.com/RobbieTheWagner/ember-math-helpers/blob/main/ember-math-helpers/package.json#L90 it's mainly this RobbieTheWagner/ember-math-helpers#2145 @RobbieTheWagner being an owner will help me with that, I will try to get new version out pretty quick |
That's probably fine. We want to release a patch change asap, but if you think you can get this merged today/tomorrow, we can hold off. Otherwise, we're doing another minor release in a week and half where we could update the dep again. Just let me know. Thanks for checking out the change. |
|
I will work on this today, but side note base line support for this addon is 4.12 just something to be aware |
|
Well I think I spoke too soon, I am now locked out from my mac. I wouldn't want to hold up this PR from to long, unless @RobbieTheWagner can merge linked PR and release new version, you can proceed with merging this PR as is, and I will make sure to follow up |
|
Closing in favor of #3043 |
π Summary
If merged, this PR will change
ember-math-helpersfrom adevDependencyto adependency.This fixes bugs when users do not have
ember-math-helpersinstalled.π οΈ Detailed description
ember-math-helperswas added as a dependency in the 4.21 release as part of the AdvancedTable work, but it was added to the wrong dependency list.π Component checklist
π¬ Please consider using conventional comments when reviewing this PR.
π PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.