Memoize AscIfDefault sorting function#44
Open
wjordan wants to merge 1 commit intohashicorp:masterfrom
Open
Conversation
Fix performance issue on systems with large number of virtual interfaces.
sean-
approved these changes
May 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the expensive sorting option in
AscIfDefaultby memoizing the default interface name.Resolves a performance issue that occurs when on systems with large number of virtual interfaces.
My use-case is a system with over 1500 virtual interfaces that was taking over 20 minutes to render the Nomad Agent's default
{{GetPrivateIP}}advertise addresses.