ui: Drop classic decorators and migrate to single-file components (GJS)#27700
Open
ui: Drop classic decorators and migrate to single-file components (GJS)#27700
Conversation
b49901c to
1af6554
Compare
c52be50 to
9554b3a
Compare
10c3e7f to
53f2098
Compare
cafcfeb to
7b778c6
Compare
da0ee4f to
be9a96f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR migrates the majority of Nomad UI components from the legacy split-file format (
.js+.hbs) into co-located GJS (Glimmer JS) single-file components (.gjs). This removes the classic decorator patterns and consolidates template + logic into a single file per component, improving colocation, readability, and alignment with modern Ember conventions.Summary of Changes
Single-File Component (GJS) Migration
Migrated 70+ components from split
.js/.hbsformat to single-file.gjs, including:page-layout,global-header,gutter-menutoggle,stepper-input,two-step-button,copy-button,loading-spinnertopo-viz,flex-masonry,chart-primitives,scale-events-chartjob-editor,job-version,job-page/service,job-statuspanelsallocation-service-sidebar,task-sub-row,task-subnavbreadcrumbs,region-switcher,subnavcomponentsvariable-form,policy-editor,token-editorfscomponentsdascomponentsBug Fixes & Reactivity
EmberObject.getin logger helper (use native property access)did-updatemodifier imports across componentsTest Updates
Testing & Reproduction steps
All existing tests pass after migration. No new features or behavioral changes—this is a refactoring/modernization PR only.
Links
Contributor Checklist
changelog entry using the
make clcommand.ensure regressions will be caught.
and job configuration, please update the Nomad product documentation, which is stored in the
web-unified-docsrepo. Refer to theweb-unified-docscontributor guide for docs guidelines.Please also consider whether the change requires notes within the upgrade
guide. If you would like help with the docs, tag the
nomad-docsteam in this PR.Reviewer Checklist
backporting document.
in the majority of situations. The main exceptions are long-lived feature branches or merges where
history should be preserved.
within the public repository.
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.