ui: NMD 917 - UI not updating on region switch#27886
ui: NMD 917 - UI not updating on region switch#27886arunstanhc wants to merge 13 commits intomainfrom
Conversation
…s, clearing store and refreshing routes
… the routes only if region changed and is query param only transition
…during region switch
…ta from region switch
…ring task-linked variables are loaded and the link rerenders correctly.
…tead assert against fields from the Mirage-created job loaded by the test.
…ob-detail data with the selected region.
tehut
left a comment
There was a problem hiding this comment.
@arunstanhc I really appreciated you including the configuration files, it really sped up my replication efforts. Thank you!
I'm sorry that #27899 landed while I was still reviewing this. I was able to run everything as described and was able to follow the logic but I don't want to approve it before you've rebased since there will probably be some substantive changes to bring everything into ember 6.0
@tehut Sure, glad that it was useful. No worries, I have now resolved the merge conflicts and everything looks fine after a round of testing. Please take a look again. Thank you! |
Description
This PR fixes the issue when allocations view is not updated when switching region. This leads to user seeing incorrect data and further errors when they try to interact with it - for eg. trying to access a job not existing in the newly switched region.
The changes in the PR are as below:
store.unloadAllwhich was causing rendering errors and replaced it withroute.refreshto reload active route models for the selected regionTesting & Reproduction steps
To reproduce the issue, set up Nomad instances with two regions and deploy a job to the federated cluster.
To verify the fix, please make another build with the PR branch and repeat the above steps
You should see updated data for relevant region without any errors
Including the files mentioned above for reference:
NMD917-test-files.zip
Links
JIRA
Contributor Checklist
changelog entry using the
make clcommand.ensure regressions will be caught.
and job configuration, please update the Nomad product documentation, which is stored in the
web-unified-docsrepo. Refer to theweb-unified-docscontributor guide for docs guidelines.Please also consider whether the change requires notes within the upgrade
guide. If you would like help with the docs, tag the
nomad-docsteam in this PR.Reviewer Checklist
backporting document.
in the majority of situations. The main exceptions are long-lived feature branches or merges where
history should be preserved.
within the public repository.
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.