ui: fix versions page showing 'No Changes' on initial SPA navigation#27895
Open
nh2 wants to merge 1 commit intohashicorp:mainfrom
Open
ui: fix versions page showing 'No Changes' on initial SPA navigation#27895nh2 wants to merge 1 commit intohashicorp:mainfrom
nh2 wants to merge 1 commit intohashicorp:mainfrom
Conversation
Add `{{did-insert this.versionsDidUpdate}}` to ensure diffs are fetched
on initial render of the Versions page, not only when versions change
after render. The `did-update` modifier alone does not fire on initial
render, causing diffs to never be loaded when navigating from Overview
to Versions via SPA (the common case).
Generative AI disclosure: Root cause found with Claude Opus 4.6
in Roo Code. Reviewed and tested manually.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Nomad UI was bugged: It would not show job diffs on first load when doing navigation to
Versionsinside the SPA.See commit message for more details.
I tested this change against Nomad
v1.11.3only.One needs to run
make dev-uito regeneratecommand/agent/bindata_assetfs.goto test this change.Testing & Reproduction steps
Note I let an LLM generate these for me (as I ran the entire multi-hour original investigation with it) and then used them as my repro (so they work):
Details
Prerequisites: A running Nomad cluster (even
nomad agent -devsuffices).Setup — create a job with 2 versions:
Verify the API returns a diff:
Reproduce the bug (before fix):
watchListservice).http://localhost:4646/ui/jobs/test-versions-diffVerify the fix (after fix):
Repeat steps 1-4 above. Version #1 should now show "See 1 Change" with the correct diff (Count: 3 -> 1).
Root cause:
{{did-update this.versionsDidUpdate this.job.versions}}only fires whenthis.job.versionschanges after the template's initial render. On SPA navigation from Overview to Versions, the versions are already loaded and cached at the current blocking-query index, sodid-updatenever fires,versionsDidUpdate()is never called, and diffs are never fetched. Adding{{did-insert this.versionsDidUpdate}}ensures diffs are fetched on initial render of the Versions page.Contributor Checklist
changelog entry using the
make clcommand.ensure regressions will be caught.
and job configuration, please update the Nomad product documentation, which is stored in the
web-unified-docsrepo. Refer to theweb-unified-docscontributor guide for docs guidelines.Please also consider whether the change requires notes within the upgrade
guide. If you would like help with the docs, tag the
nomad-docsteam in this PR.Reviewer Checklist
backporting document.
in the majority of situations. The main exceptions are long-lived feature branches or merges where
history should be preserved.
within the public repository.
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.