cli: Add shutdown_delay to full job init output to fix warning.#27900
Open
cli: Add shutdown_delay to full job init output to fix warning.#27900
shutdown_delay to full job init output to fix warning.#27900Conversation
jrasell
added
backport/ent/1.10.x+ent
Member
|
Hey nice. There are other examples too, namely |
Nomad recently added a warning to the CLI output when a job includes a service in a group/task that doesn't have a shutdown delay configured. This change brings the Nomad example job specs created by the init command inline with our reccommendations.
jrasell
force-pushed
the
b-add-shutdown-delay-job-init
branch
from
af33d46 to
608094a
Compare
gulducat
approved these changes
May 6, 2026
Member
gulducat
left a comment
gulducat
left a comment
There was a problem hiding this comment.
LGTM!
Just noting that there's no change to example-short.nomad.hcl because it has no service. Although, we could add a provider=nomad service in there... 🤷
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nomad recently added a warning to the CLI output when a job includes a service in a group/task that doesn't have a shutdown delay configured.
This change brings the Nomad example job spec created by the init command inline with our recommendations.
Links
Related: #27782
Contributor Checklist
changelog entry using the
make clcommand.ensure regressions will be caught.
and job configuration, please update the Nomad product documentation, which is stored in the
web-unified-docsrepo. Refer to theweb-unified-docscontributor guide for docs guidelines.Please also consider whether the change requires notes within the upgrade
guide. If you would like help with the docs, tag the
nomad-docsteam in this PR.Reviewer Checklist
backporting document.
in the majority of situations. The main exceptions are long-lived feature branches or merges where
history should be preserved.
within the public repository.