f-ui: Improve ACL permission error message to prompt sign-in check#27904
Open
sreekanthkk96 wants to merge 2 commits intomainfrom
Open
f-ui: Improve ACL permission error message to prompt sign-in check#27904sreekanthkk96 wants to merge 2 commits intomainfrom
sreekanthkk96 wants to merge 2 commits intomainfrom
Conversation
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
jrasell
reviewed
May 6, 2026
Member
jrasell
left a comment
There was a problem hiding this comment.
Hi @sreekanthkk96 and thanks for raising this PR.
It solves the direct user issue but I wonder if we can improve upon this by passing an isAuthenticated option to messageFromAdapterError which would allow us to show two distinct messages:
- Not signed in:
"You are not signed in. Please sign in to perform this action." - Signed in, insufficient token → `"Your ACL token does not grant permission to ${actionMessage}."
Curious of your thoughts here on UX and implementation?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the error message for ACL permission failures to be more actionable by suggesting that users verify they are signed in. Previously, when users encountered a 403 Forbidden error, the message only stated that their ACL token didn't grant permission, which could be confusing for users who weren't logged in at all.
The updated error message now reads:
Your ACL token does not grant permission to ${actionMessage}. Please ensure you are signed in.This change improves the user experience by providing a clear next step when encountering permission errors.
Testing & Reproduction steps
Manual Testing:
To reproduce this error message:
🐛 YOU SHOULD SEE THE ERROR
Links
Before
After
Contributor Checklist
changelog entry using the
make clcommand.ensure regressions will be caught.
and job configuration, please update the Nomad product documentation, which is stored in the
web-unified-docsrepo. Refer to theweb-unified-docscontributor guide for docs guidelines.Please also consider whether the change requires notes within the upgrade
guide. If you would like help with the docs, tag the
nomad-docsteam in this PR.Reviewer Checklist
backporting document.
in the majority of situations. The main exceptions are long-lived feature branches or merges where
history should be preserved.
within the public repository.
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
No changes to security controls. This PR only modifies the error message text to be more user-friendly by suggesting users verify they are signed in when encountering ACL permission errors. The underlying authentication and authorization mechanisms remain unchanged.