fix: issue where archive was being closed before the file finished writing causing corrupt TerraformAssets #3873
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mutahhir
requested review from
ansgarm and
DanielMSchmidt
and removed request for
a team
DanielMSchmidt
approved these changes
May 20, 2025
mutahhir
changed the title
|
@mutahhir @DanielMSchmidt any plans to merge and release this fix? We have to use currently mixed versions as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
Fixes #3858
Description
I'm not sure why this only showed up once we upgraded the version of
archiverin the last release, but intuitively this should've always been a problem. Was led to this by @DarkAtra's comment ❤️ .Checklist