Fix warning for -Werror build in Circle CI
#4727
Conversation
| @@ -5,7 +5,6 @@ import Control.Arrow ((>>>)) | |||
| import Control.Exception (throw) | |||
| import Control.Lens ((^.)) | |||
| import Data.Maybe (fromJust) | |||
| import Data.String.Interpolate (__i) | |||
There was a problem hiding this comment.
Thanks for the fix and sorry for the extra work.
I am aware that this import line is redundant after #4717 is merged. However, I am surprised that this causes CI failures since the circleci check did pass before I merged #4626.
I have done some digging and found the cause. The default behavior of GitHub's actions/checkout is merging the PR branch and the target branch. On the contrary, the default behavior of circleci's checkout does not do the merge. Both of them can be configured to change to another behavior. Here is GitHub's doc. I do not find the doc of circleci, but it should be doable.
It is debatable whether we should do the merge in the checkout action or not. However, having different behaviors in different CI checks is just wrong, I think. We should choose one single checkout behavior for all CI checks.
Circle CI runs its builds with
-Werror. Thus, we need to fix the warning that was accidentally introduced.See for example the logs of the job https://circleci.com/gh/haskell/haskell-language-server/70398 in #4726