-
Notifications
You must be signed in to change notification settings - Fork 94
Fix struct dirent d_type macro test #348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Credit to Andrew Gunnerson (@chenxiaolong)
@sjshuck could you add a test please? |
I'm a little stuck on how to skip the test if Do all test containers have a |
I think so, these are generic CI machines, not bare minimum containers. Is |
I'm not sure TBH. I don't know how standard of a macro that is, how much it has to do with GNU, Linux, ... I did the test another way, compiling optimistically with |
a459fc8
to
9eb439b
Compare
9eb439b
to
c18caa0
Compare
…Type /proc/self is guaranteed to exist as a symlink on Linux and procfs has emitted its d_type for decades.
Temporarily changed back to the incorrect
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
Anything else needed of me? |
Fixes #347. Credit to Andrew Gunnerson (@chenxiaolong).
Test program:
Output for unix-2.8.7.0:
Output with this change: