build with ghc-9.2 #167
Open
build with ghc-9.2 #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| #endif | ||
|
|
||
| {- | ||
| deriving instance SemialignWithIndex () Option |
There was a problem hiding this comment.
Do you want to move the #endif to below this block comment, so that if it's ever uncommented it will do the right thing?
| (_, True) -> Done | ||
| #if !MIN_VERSION_base(4,16,0) | ||
| _ -> Skip (sa, sb, Nothing, False) | ||
| #endif |
There was a problem hiding this comment.
Why did you need to do this? It compiles fine for me without making this change.
There was a problem hiding this comment.
Without this I get a warning from GHC about a redundant pattern match. Newer versions of GHC are smarter in recognizing those than previous versions.
There was a problem hiding this comment.
I'd rather match above with av@(Just x)
It wasn't obvious to me why the branch is redundant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tested with
cabal build all --allow-newer=base,template-haskell,ghc-prim,ghc-bignum cabal test all --allow-newer=base,template-haskell,ghc-prim,ghc-bignumThis currently still requires the following source dependencies when building with ghc-9.2