ETT-1118: Use AdobeFlate compression with imgsrv #172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* avoids deprecation warning from netpbm * fixes issue with image showing up as a "negative" in preview on Mac
Member
Author
|
Expected behavior is that:
|
moseshll
approved these changes
Dec 8, 2025
Contributor
moseshll
left a comment
moseshll
left a comment
There was a problem hiding this comment.
Works as advertised. Happy to see the additional testing and the way it has been cleaned up, all good! APPROVE
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested both an 8-bit greyscale and 24-bit color image compressed with
pamtotiff -adobeflatewith:I also changed the tests to use exiftool rather than identify from imagemagick because imagemagick didn't differentiate between Deflate and AdobeDeflate compression (it just reports 'zip' for both), and exiftool (despite being somewhat of a pain to work with) is already a dependency.