ETT-1210: Don't create GeoIP2-Country.mmdb symlink by default #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fake "always_us.mmdb" and "always_nonus.mmdb" files work with the babel apps but not apparently with the version of geoip we have for PHP. This avoids that problem by: * When repo is checked out, geoip/GeoIP2-Country.mmdb symlink won't exist * This symlink and real GeoIP mmdb files are gitignored, so we can put real files there in test/preview/whatever and they won't get clobbered by the symlink
Member
Author
|
@carylwyatt @moseshll I'm not really sure how we'll test or reasonably review this as such other than making sure the tests pass. What you can check for now is that if you do a catalog search with preview.catalog.hathitrust.org in a new private/incognito window then pdus items show as viewable. Let me know if you have any other thoughts though. |
carylwyatt
approved these changes
Dec 18, 2025
Member
carylwyatt
left a comment
carylwyatt
left a comment
There was a problem hiding this comment.
This worked in a private window on preview. Approve!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fake "always_us.mmdb" and "always_nonus.mmdb" files work with the babel apps but not apparently with the version of geoip we have for PHP. This avoids that problem by: