Ett 1200 facet search error #107
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moseshll
approved these changes
Dec 15, 2025
Contributor
There was a problem hiding this comment.
This works as expected. See the original ticket for a follow-up about the display of this previously-broken facet now that we can select it without an error -- the quotes are missing when the facet is in the "Current Filters". May be out of scope and it's just cosmetic. APPROVE
EDIT: I just put a screen shot on the ticket
aelkiss
reviewed
Dec 18, 2025
Member
aelkiss
left a comment
aelkiss
left a comment
There was a problem hiding this comment.
The main question I have is if we should be doing something more general for escaping queries. In particular it doesn't seem like this will address the issues with characters like ~ and \. Given that these don't cause issues in ls, I think it's worth seeing if we can apply the more general escaping strategy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Facet search failed because internal quotes were not accounted for.
Ticket: ETT-1200
Issue explanation:
Facet value: "Kao gu yu wen wu" bian ji bu
Solr should receive: "Kao gu yu wen wu" bian ji bu"
Solr sees: ""Kao gu yu wen wu" bian ji bu", then orphaned text bian ji bu"
Error: no field name specified
Solving the issue
/sys/Solr.php, and a couple of tests have been added ontest/SolrTest.php.How to test?
tableAuthor