ETT-829: Handle deleted records for record page #114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deleted record stubs were added to the catalog to support returning info about deleted records in OAI. While they were excluded from search results, going directly to a record with a deleted ID returned an error from the catalog. This is especially a problem when there is a redirect to another catalog ID. This ensures that deleted records redirect properly when a redirect exists, and return an appropriate 404 page otherwise. * Exclude records where deleted:true when getting a record by ID * Test for this behavior with & without a record with old_ids including the deleted record ID
Member
Author
moseshll
approved these changes
Jan 7, 2026
Contributor
moseshll
left a comment
moseshll
left a comment
There was a problem hiding this comment.
Playwright good. I hacked around with Solr admin locally so I could see these additional records in action, and I'm happy with the results.
Member
Author
|
We'll go ahead and get this deployed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deleted record stubs were added to the catalog to support returning info about deleted records in OAI. While they were excluded from search results, going directly to a record with a deleted ID returned an error from the catalog. This is especially a problem when there is a redirect to another catalog ID. This ensures that deleted records redirect properly when a redirect exists, and return an appropriate 404 page otherwise.