ETT-780: Bucket root contains obj dir #170
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I chose that because I'd thought you'd want paths to be similar the existing /sdr1 mounts on apache hosts. I actually prefer linking a lever deeper to |
Member
Author
|
Superceded by https://github.com/hathitrust/truenas-stacks/pull/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rrotter When testing before I had assumed that the root of the bucket corresponded to the 'obj' dir. However in the setup you have the bucket points to
/sdr1rather than/sdr1/obj. That works but needed some adjustment in the ingest code. Let me know if you think it would be preferable to have the bucket point to/sdr1/obj-- I don't have a strong preference.