WIP: Update to debian 13 with grok 20.0.4 #172
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* include hand-built grok (shouldn't merge this, should package as deb or at least upload to hathitrust.github.io; probably also need ARM version) * don't swallow errors from grok (for now) * update arguments for grok - SOP and EPH were spelled out and shouldn't have been
Member
Author
|
This worked for building grok locally: docker run -v ./grok:/tmp/grok -ti --rm debian:trixie /bin/bash
apt update && apt install wget cmake build-essential cmake-curses-gui exiftool libpsl-dev libjpeg62-turbo-dev pkg-config libcurl4-openssl-dev libtiff-dev libpng-dev liblcms2-dev libcli11-dev
wget https://github.com/GrokImageCompression/grok/archive/refs/tags/v20.0.4.zip
tar zxvf v20.0.4.zip
cd grok-20.0.4
cmake -E make_directory $PWD/build
cmake -S $PWD -B $PWD/build -DCMAKE_BUILD_TYPE=Release -DBUILD_SHARED_LIBS=ON -DGRK_ENABLE_LIBCURL=ON -DGRK_BUILD_JPEG=OFF -DGRK_BUILD_LCMS2=OFF -DGRK_BUILD_LIBCURL=OFF -D GRK_BUILD_LIBTIFF=OFF -DBUILD_TESTING=OFF
cmake --build $PWD/build --config Release -j 8
. /etc/os-release
cmake -S $PWD -B $PWD/build -Wno-dev -D CPACK_GENERATOR:STRING=ZIP -D CPACK_PACKAGE_FILE_NAME:STRING=grok-$ID-$VERSION_CODENAME
cmake --build $PWD/build --config RELEASE --target packagethis outputs a zip called this is probably a good starting point for deb packaging |
Member
Author
|
These Debian build scripts might also be useful in conjunction with above: https://github.com/GrokImageCompression/grok/tree/debian/master/debian (note these are not in the current main branch) |
Member
Author
|
It looks like the S3-related tests also fail in github, so that's also something we'll need to look at. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Locally, at least one relevant test is failing with respect to keeping the TIFF artist when compressing to JPEG2000; some other tests related to S3 are also failing but it might be messed up permissions on my end.
TODO: