ETT-298 addendum: fix seq/pages extraction #270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add & test `extract_pages_from_seq` method to handle `nil` seq. - `HTDownload` factory changed to never return 0 pages. - Note added to `HTDownload#pages` test.
aelkiss
approved these changes
Oct 10, 2025
Member
aelkiss
left a comment
aelkiss
left a comment
There was a problem hiding this comment.
Makes sense. I think the sample data didn't include this case.
- Add `resource_sharing` entry to gzip fixture - Update tests to reflect fixture changes
Collaborator
Author
|
This finally ran correctly and extracted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extract_pages_from_seqmethod to handlenilseq.HTDownloadfactory changed to never return 0 pages.HTDownload#pagestest.