ETT-751: Fix permissions on home directory #272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
aelkiss
commented
Oct 17, 2025
aelkiss
commented
- Sometimes we run as users other than 1000:1000 e.g. when we need to write to specific NFS directories
- This user still needs to be able to read the homedir
- useradd was creating the directory with permissions 700
- elsewhere setting WORKDIR first creates the directory
- however that ends up with the directory being owned by root, which won't work since npm needs to write there when it does its install
- so... rather than relying on WORKDIR to make the directory (but with different wrong permissions) we just chmod to to make sure we end up with what we want.
* Sometimes we run as users other than 1000:1000 e.g. when we need to write to specific NFS directories * This user still needs to be able to read the homedir * useradd was creating the directory with permissions 700 * elsewhere setting WORKDIR first creates the directory * however that ends up with the directory being owned by root, which won't work since npm needs to write there when it does its install * so... rather than relying on WORKDIR to make the directory (but with different wrong permissions) we just chmod to to make sure we end up with what we want.
moseshll
approved these changes
Oct 17, 2025
Collaborator
moseshll
left a comment
moseshll
left a comment
There was a problem hiding this comment.
Built and run locally, permissions are good compared to doing same on main branch. APPROVE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.