ETT-339 Metadata Verifier Can't Detect Suppressed Catalog Records #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add an "expected delta" to the comparison between monthly Zephir file and catalog archive derivative - Delta is based on matching lines in `[ZEPHIR_DATA]/full/zephir_full_monthly_rpt.txt` - This is the "more yucky" solution since we `grep -c` to find the number of suppressed records - The "less yucky" solution would be to have postZephir.pm write the total number, but we'd still have to grep to extract that - Both solutions are brittle in depending on a logfile no one really cares about
moseshll
commented
Jun 24, 2025
mwarin
approved these changes
Jun 25, 2025
Contributor
mwarin
left a comment
mwarin
left a comment
There was a problem hiding this comment.
I don't see anything particularly yucky here. Noted one possible additional logging opportunity, but no need to stand in the way of an APPROVE.
- Log error if `count_suppressed_records` grep command fails
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the ticket description:
[ZEPHIR_DATA]/full/zephir_full_monthly_rpt.txtgrep -cto find the number of suppressed recordsReviewer: does a high-level scrutiny cause only low to moderate discomfort? I'm willing to tolerate some yuckiness to get this in place by July 1.