ETT-407 Metadata Processing Verifier Misinterprets grep Exit Status #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Suppress spurious warning caused by `grep` exit status being 1. - Real `grep` errors are 2 and up, according to the man page.
mwarin
approved these changes
Jul 14, 2025
Contributor
mwarin
left a comment
mwarin
left a comment
There was a problem hiding this comment.
Oh, what a nasty little surprise -- that you can't rely on Process:Exitstatus#success? here. But in light of that, the changes make sense
Approve.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
grepexit status being 0 or 1 on success.greperrors are 2 and up, according to the man page.Process:Exitstatus#success?and do a numeric comparison.