ETT-420 Update Database Credentials #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… keys. - Do away with connection string and simplify `Database` class in imitation of holdings-backend and others. - Use `connection_validator` extension with Sequel connection to allow reconnects. (ETT-430)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we are updating the sealed DB credentials, this is a good time to name them appropriately and decruft.
MARIADB_*ENV to replace obsoleteDATA_API_*… keys.Databaseclass in imitation of holdings-backend and others.connection_validatorextension with Sequel connection to allow reconnects. (ETT-430)Reviewer: the new version is much closer to the standard incantation found in post_zephir_processing, holdings-backend, &c.