Skip to content

🔒 Fix reverse tabnabbing vulnerabilities in external links#78

Open
hatimhtm wants to merge 1 commit intomainfrom
fix-reverse-tabnabbing-15653099920262533727
Open

🔒 Fix reverse tabnabbing vulnerabilities in external links#78
hatimhtm wants to merge 1 commit intomainfrom
fix-reverse-tabnabbing-15653099920262533727

Conversation

@hatimhtm
Copy link
Copy Markdown
Owner

🎯 What:
Fixed a reverse tabnabbing vulnerability in app/contact/page.tsx and across the entire application by adding the rel="noopener noreferrer" attribute to all external links that use target="_blank". Additionally fixed a linting issue in app/not-found.tsx related to JSX comments.

⚠️ Risk:
If left unfixed, links using target="_blank" without rel="noopener noreferrer" pass a reference to the window.opener object to the newly opened page. A malicious website could use this reference to redirect the original application's page to a phishing site, potentially stealing user credentials or sensitive information.

🛡️ Solution:
The fix systematically adds the rel="noopener noreferrer" attribute to all instances of <a target="_blank"> across all files, including:

  • app/contact/page.tsx
  • app/work/page.tsx
  • app/work/[slug]/CaseStudyClient.tsx
  • app/page.tsx

This severs the connection between the newly opened tab and the original tab, completely eliminating the vulnerability. We also ensured the fix didn't break functionality by running lint and build checks.


PR created automatically by Jules for task 15653099920262533727 started by @hatimhtm

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 29, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
portfolio Ready Ready Preview, Comment Mar 29, 2026 6:58pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant