style: change x86 inline asm from AT&T syntax to intel#63
Merged
Conversation
As discussed in [#59 (comment)][1], it's good to standardize on a syntax, and @mystor and I both have a minor preference for Intel over AT&T syntax. Also, when the work started in PR #61 merges, we will be showing disassembly in crash screens using Intel syntax, so we should use consistent syntax in source. This PR changes inline assembly to use Intel syntax. In cases where the inline assembly is a single instruction with no syntactic differences between AT&T and Intel syntax (e.g. "cli", "hlt", et cetera), I did not add the "intel" flag to the `asm!` macro. I can if we'd prefer this to be explicit, but the syntax is currently equivalent. [1]: #59 (comment) Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Owner
Author
|
|
hawkw
changed the title
mystor
approved these changes
Jan 20, 2020
Owner
Author
|
@iximeow any hot takes? |
iximeow
approved these changes
Jan 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #59 (comment), it's good to standardize on a
syntax, and @mystor and I both have a minor preference for Intel over
AT&T syntax. Also, when the work started in PR #61 merges, we will be
showing disassembly in crash screens using Intel syntax, so we should
use consistent syntax in source.
This PR changes inline assembly to use Intel syntax. In cases where the
inline assembly is a single instruction with no syntactic differences
between AT&T and Intel syntax (e.g. "cli", "hlt", et cetera), I did not
add the "intel" flag to the
asm!macro. I can if we'd prefer this tobe explicit, but the syntax is currently equivalent.
Signed-off-by: Eliza Weisman eliza@buoyant.io