Open
Conversation
Member
|
is "sumbit" the right event? What do normal listviews do, or dropdown for example, i think its just "change", no? |
Contributor
Author
|
Yes it's Change. But Imagine just using the keyboard, when you press the
down or up it , it does a change. So the list picker closes.
(Also imagine multi items listviews, which doesn't really work for now, you
should be able to select multiple items, so doing multiple changes, but
only one submit)
I think there's a certain logic as seeing the panel as some kind of form.
Once it's submitted, it should close.
Le jeu. 8 févr. 2024 à 15:02, Ian Harrigan ***@***.***> a
écrit :
… is "sumbit" the right event? What do normal listviews do, or dropdown for
example, i think its just "change", no?
—
Reply to this email directly, view it on GitHub
<#581 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADBNBIXROER2MEVNKUICFQ3YSTLF5AVCNFSM6AAAAABC7ZJEB6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZUGE4DKMBRGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Member
|
i wonder if a generic "UIEvent.SELECTED" (or UIEvent.SELECT) makes more sense? |
Contributor
Author
|
Hmm, I think for normal list views SELECTED is good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a dispatch SUBMIT event to the list views when there's a confirm action.
Added an ActionStart event to ItemPicker. I don't like it to much, feels it goes against the logic of the dynamic trigger event, but don't see how else to do it. (( In fact I feel maybe MouseEvents should also be action events, but that would too much of an undertaking :P)
No CANCEL action yet. I wonder if I should add directly to the listview. But don't feel it will be useful except in the case the listview is inside of an item picker