Fix a rare platform-specific crash when operating on opacity.#696
Open
AbnormalPoof wants to merge 1 commit intohaxeui:masterfrom
Open
Fix a rare platform-specific crash when operating on opacity.#696AbnormalPoof wants to merge 1 commit intohaxeui:masterfrom
AbnormalPoof wants to merge 1 commit intohaxeui:masterfrom
Conversation
Contributor
|
While operating on the properties of a target component, the Actuator class will enter this block: var isVariant = false;
if (start != null && Std.isOfType(start, VariantType)) {
try { // some neko strangness here with exception being thrown on the switch
switch (start) {
case VariantType.VT_String(v):
start = v;
isVariant = true;
case _:
}
} catch (e:Dynamic) { }
}In rare circumstances, the innermost block of code will be accessed, despite This results in the following issue, which this PR reliably resolves: FunkinCrew/Funkin#5011 In the above issue, the crash happens when |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
startandendwould sometimes be integers, but still fall into theVariantTypeswitch case. This would cause a memory access violation on macOS specifically!This PR adds more strict type checking, which fixes the crash entirely.