Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plan: Add Filament Types as First-Class Citizens
Problem Statement
TeamTone currently mixes different filament types (PLA, PETG, ASA, ABS, etc.) in the same recommendation set. Users can't print a project using mixed materials, so recommendations should be filtered by filament type.
Solution Overview
Add
filament_types.yamlandfilament_types.pyto define base types and classify materials using prefix matching. No need to list every variant - "PLA Silk", "PLA Matte", "PLA CF" all match to PLA.Files to Create
1.
teamtone/filament_types.yamlSimple configuration defining base types only.
2.
teamtone/filament_types.pyModule for classification using prefix matching.
Key Functions:
Files to Modify
3.
teamtone/filament_colors.pyAdd type-filtered query functions.
New Functions:
4.
teamtone/main.pyAdd filament type selection to CLI flow.
New Function:
Modified Flow:
This flow lets users first identify their team, then filter by the filament type they plan to use.
Modified Function:
Implementation Steps
Save this plan to
plans/filament-types.mdCreate
filament_types.yamlCreate
filament_types.pyclassify_material()using prefix matchingget_base_types()andis_filament_type()helpersUpdate
filament_colors.pyget_filaments_by_hex_and_type()find_similar_filament_colors_by_type()Update
main.pyselect_filament_type()functiondisplay_team_colors()to acceptfilament_typeparameterCreate tests in
tests/test_filament_types.pyExample Output (After Implementation)
Verification
pytest tests/to verify all tests pass