Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes manufacturer filtering in
FilamentProfilesScraperprogrammatic by introducing amanufacturerproperty on the baseFilamentScraperclass. Dedicated scrapers now self-identify, eliminating the need for hardcoded manufacturer lists.Key Changes
manufacturerproperty toFilamentScraperthat returnsNoneby defaultPolymakerScraper,SunluScraper, andOvertureScrapernow return their manufacturer nameFilamentProfilesScraperusesget_dedicated_manufacturers()instead of a hardcoded tupleget_dedicated_manufacturers()in__init__.pyintrospects all scraper classes to build the exclusion setBenefits
HatchboxScraperwithmanufacturer = "Hatchbox") automatically filters that manufacturer from the aggregate scraperSCRAPER_CLASSESregistry eliminates duplicate maintenancemanufacturerproperty is properly typed asstr | NoneFiles Changed
filament_sites/base.pymanufacturerproperty with docstringfilament_sites/__init__.pySCRAPER_CLASSESregistry andget_dedicated_manufacturers()filament_sites/filamentprofiles.pyfilament_sites/polymaker.pymanufacturerproperty returning"Polymaker"filament_sites/sunlu.pymanufacturerproperty returning"SUNLU"filament_sites/overture.pymanufacturerproperty returning"Overture"filament_sites/test_filamentprofiles.pyTestDynamicManufacturerFilteringtest classTest Plan
pytest teamtone/fetch/filament_sites/passes (115 tests)get_dedicated_manufacturers()returns lowercase set🤖 Generated with Claude Code