Open
Conversation
Will help catch package and CMake issues Bump setuptools in CI Seems to be needed to get catkin lint working Add informational noetic run
Ignore Python 3 file
Naming, casing issues
Declaring message dependencies correctly, mostly Add permissive licenses to code we own Install executables, include directories Add additional dependencies
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds PEP8 enforcement to CI
Formats all code to match PEP8
Add
catkin lintto CIFixes all catkin lint violations
PEP8 is largely a cosmetic thing, but will catch some minor bugs too. catkin lint is more important for making sure packages are set up in a way that their behavior is predictable in different ROS configurations