Quickswap sources using the Input menu options #423
Conversation
sanderpuh
changed the title
|
Would've been nice if you left me as the author of the code I wrote by cherry picking from my branch properly. The changes, however look nice, good job. A little fronted documentation of what race mode means would be appreciated by many users, I think. Also, squashing equally named commits would serve comprehensibility for the future imho 😉 |
|
Nice, thanks, how can I test it? |
Thanks for the tip, still new to using GitHub, will keep them in mind! Frontend documentation in the goggles GUI you mean? Other option would be to drop the config in the |
GitHub does an automatic build to check the code. I think you could use that build to test, can be found under the |
@DarthCedius I've made a few more changes, settings weren't stored properly when changing the setting from |
This comment was marked as off-topic.
This comment was marked as off-topic.
|
Pilots may not associate the terminology
|
|
@nerdCopter Agreed, naming scheme should be in line. Regarding the two options for implementation, I'm fine with either. Adding it to the inputs menu keeps everything in one page, which would keep things clean IMO.
Since the Inputs menu is new, we can add a description for each option, including these two. Who can be the deciding factor in choosing which path to follow for implementation? |
i like that, albeit i'm "nobody" to decide.
other interested community members or @ligenxxxx (or yourself 😉) . |
it's working great thanks, maybe you should add a temporary OSD info to state which input you are on. |
@DarthCedius |
The more I think of it, the more I like that option too. Keeps the OSD menu cleaner and both options are integrated on one page. @ligenxxxx do you agree? If yes, I'll rework the code to remove the config in the |
|
@sanderpuh , i'm happy to test after commit/push on weekends. i don't have any hdmi to test that part though. |
Current commit seems to be working well, been using it for a while now on my own goggles without any issues. I've also implemented a beep on my end when sources are swapped as an audible indicator. That being said, I'll rework the code to have 2 more options on the inputs page, one will be 'cycle sources' and the other will be 'toggle sources'. The After implementation of these two items, we could further enhance by implementing #395 from @qvasic - Add a beep option to the OSD menu with setting |
|
This PR can be closed when PR #433 is merged. |
5 participants
@Master92 did quite a lot of coding already, I took inspiration from his work which allows cycling through the source options.
On top of that I've added the option to choose to cycle only between HDZero and the expansion module, which is most useful on races where people use both systems, and for people flying lots of whoops with both systems.
I've added
Toggle Modeto theAuto Scanscreen, because this seemed the most logical to me. Open to suggestions!The
Cyclesetting does cycle through all source options, theRacesetting switches between the expansion module and HDZero. In caseRaceis selected, and anything other than the expansion module or HDZero is active, it will switch to HDZero when the button is pressed to switch sources.The dropdown menu on the
Inputscreen now has the optionToggle sourceadded to the list, in this case I've set it on theRight long:button (not as default).The code also takes into account that the expansion module can be switched off automatically, which is taken care of in the quickswap too.