Modernise React and JavaScript code#1
Open
ultraslayyy wants to merge 3 commits intohealthgovau:masterfrom
Open
Modernise React and JavaScript code#1ultraslayyy wants to merge 3 commits intohealthgovau:masterfrom
ultraslayyy wants to merge 3 commits intohealthgovau:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modernisation of all the React and JavaScript code in the project.
Yes, modules were changed back to regular CSS as modules only add extra complexity, and it's benefits don't mean anything at this level of simplicity. If this was a larger project I'd consider keeping modules, but it's not worth in something this simple (changing back is easy though if it's a style/design choice)
As to why I bothered making this PR in the first place...
It's because I could and wanted to. I thought it'd be a little fun project for me—an experienced JavaScript/TypeScript developer—to refactor an old React project for the thrill of it. I have no expectation that this would be merged, I just thought it'd be fun to do