[#0000000000] bump phlex-icons and phlex-rails dependencies #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- phlex-rails is at a 4-month release candidate - phlex-icons >= 2 requires the updated phlex-rails
- breaking changes from 0.4.2, thus the major version bump
hedgeye-bnovak
approved these changes
Feb 6, 2025
hedgeye-bnovak
left a comment
hedgeye-bnovak
left a comment
There was a problem hiding this comment.
Approved feel free to coordinate the rest. not merging
hedgeye-sdeming
approved these changes
Feb 6, 2025
Contributor
hedgeye-sdeming
left a comment
hedgeye-sdeming
left a comment
There was a problem hiding this comment.
You covered all of the upgrades! Looks good.
jrogers-hedgeye
deleted the
update-phlex-icons-and-phlex-rails-dependencies
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/story/show/0000000000
phlex-railsis still in release candidate stage (since Nov'24!), but updatingphlex-iconsrequires updating that dependency. 😢I've run the storybook and fixed the code. Everything seems to be fine.
Required changes for libs/apps depending on this gem
Phlex::Iconreferences toPhlexIconunsafe_rawtoraw(safe(my_string))