Merged
Conversation
Add a CI job that tests hegel-rust against the oldest supported hegel-core version for the minimum supported protocol version. The job reads SUPPORTED_PROTOCOL_VERSIONS from runner.rs, fetches the protocol-to-core version mapping from hegel.dev/api/versions.json, and runs the test suite using a wrapper script that pins hegel-core to that minimum version via HEGEL_SERVER_COMMAND.
Replace the nonexistent hegel.dev/api/versions.json endpoint with a local protocol-core-versions.json mapping file. Fix the zizmor template-injection lint by passing the hegel-core version through an env var instead of expanding it directly in the run block.
…m TempRustProject child env
The Rust library requires --stdio mode, which was added in hegel-core 0.2.3. The protocol-core-versions.json was mapping protocol 0.6 to hegel-core 0.2.1, which does not support --stdio. Update all pre-0.8 mappings to 0.2.3.
Member
Author
|
@claude the recent changes are terrible and hacky. Please go back to the version which failed CI but was actually correct. |
Simpler approach: install the pinned hegel-core version as a real tool on PATH, then pass the resolved binary path via HEGEL_SERVER_COMMAND. Also moves the step output into an env block to avoid zizmor template-injection warnings.
Liam-DeVoe
commented
Apr 3, 2026
…in-protocol Apply review suggestion to remove redundant name/comments in the min-version CI step. Skip antithesis tests in the min-protocol job since they spawn subprocess projects that inherit HEGEL_SERVER_COMMAND and the old hegel-core doesn't support them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #39.
Claude-written summary
Summary
test-min-protocolCI job that tests hegel-rust against the oldest supported hegel-core versionSUPPORTED_PROTOCOL_VERSIONSfromrunner.rsto determine the minimum protocol versionhegel.dev/api/versions.jsonand pins hegel-core to the corresponding oldest version viaHEGEL_SERVER_COMMANDPart of the cross-repo protocol version mapping system (website + hegel-core + hegel-rust).
Test plan
test-min-protocoljob runs successfully onceversions.jsonis deployed to hegel.devrunner.rs