Fixed zombie overlay#47
Open
almostcake wants to merge 1 commit intoheigeo:gh-pagesfrom
Open
Conversation
AlexCortinas
added a commit
to AlexCortinas/leaflet.wms
that referenced
this pull request
Feb 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scenario: change map extent (position, zoom), overlay starts update, but image loading takes long time (service is busy or whatever). While it's loading, remove wms.overlay layer from map (for example, to hide it, as we do in our project), but "buffer" overlay is still on map, and when it is loaded, it becomes "zombie" one, which is nowhere referenced.
Sample image