Refactor Filter Processing Architecture and Introduce CQRS-Based Domain Model#5
Open
Refactor Filter Processing Architecture and Introduce CQRS-Based Domain Model#5
Conversation
ericges
changed the title
ericges
force-pushed
the
feat/refactor-abstraction
branch
from
ca566db to
61239dc
Compare
There was a problem hiding this comment.
Pull request overview
This pull request implements a major architectural refactoring of the Flare Bundle, introducing a CQRS-based domain model with significant changes to the filter processing architecture. The PR refactors the codebase from a mutable, model-centric approach to an immutable, specification-based architecture with a clear separation between domain models, specifications, contexts, and projectors.
Changes:
- Introduces a new Engine/View/Context/Projector architecture for list rendering
- Replaces FilterDefinition and related classes with immutable Specification objects
- Refactors SortDescriptor to SortOrderSequence with improved validation
- Adds translation files for filter and list type labels
- Removes deprecated managers and builders (TranslationManager, TemplateManager, ListViewBuilder, etc.)
Reviewed changes
Copilot reviewed 213 out of 214 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| translations/flare_*.php | New translation files for list types and filter elements |
| templates/backend/be_filter_info.html.twig | Backend template for filter information display |
| templates/_paginator_styles.html.twig | Reusable paginator styles macro |
| src/Engine/* | New view engine architecture with contexts, projectors, and views |
| src/Specification/* | Immutable specification objects replacing mutable models |
| src/Sort/* | Refactored sorting with SortOrder and SortOrderSequence |
| src/Query/* | Reorganized query building with factories |
| src/Registry/* | New registries for projectors, filter collectors, and invokers |
| src/Model/* | Updated models to implement new interfaces |
| src/FilterElement/* | Updated to use new FilterInvocation and events |
| src/DependencyInjection/* | New AsFilterInvoker attribute and compiler passes |
| contao/templates/* | Updated templates for new architecture |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ction architecture
…s and update flare_base template for headline validation
…nd enhance Env class with dynamic caching and static calls
…lper and restructuring dynamic caching
…, and refactor SqlHelper and ChoicesBuilderFactory
…e namespaces for clarity
…query manipulation with new modifiers
…ne query handling across multiple classes
…structure related namespaces for consistency
… `FlareException` for invalid identifiers
…ableAliasRegistry` and `ListExecutionContext` for improved query table management
… flexibility and attribute-based configuration
…ll usages for improved consistency and clarity
…terContextManager`, and `ArrayFieldChoice`, along with related references
…xception in `ListQueryDirector`
…` and related usages for clarity and consistency
…eorder `targetAlias` handling logic in `FilterExecutor` for proper event interception
… fluent setters, and update doc comments in `FilterDefinition`
…ue processing across filter elements and update related methods to support contract integration
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 235 out of 237 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.