Skip to content

Madninja/adjust wifi info #878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
madninja wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Madninja/adjust wifi info #878

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e10b0fe
deprecate wifi tilt info, correct docs for azimuth
madninja Mar 15, 2025
6a8adee
attempting fixes
madninja Mar 15, 2025
9cd7511
fix names in backfill script
bryzettler Mar 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions packages/helium-admin-cli/src/backfill-mobile-deployment-infos.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@ type WifiInfo = {
antenna: number;
elevation: number;
azimuth: number;
mechanicalDownTilt: number;
electricalDownTilt: number;
deprecatedMechanicalDownTilt: number;
deprecatedElectricalDownTilt: number;
};
};

Expand All @@ -52,8 +52,8 @@ const hasDeploymentInfo = (wi: WifiInfo) => {
wi.deploymentInfo.antenna ||
wi.deploymentInfo.elevation ||
wi.deploymentInfo.azimuth ||
wi.deploymentInfo.mechanicalDownTilt ||
wi.deploymentInfo.electricalDownTilt
wi.deploymentInfo.deprecatedMechanicalDownTilt ||
wi.deploymentInfo.deprecatedElectricalDownTilt
);
};

Expand Down Expand Up @@ -146,8 +146,8 @@ export async function run(args: any = process.argv) {
antenna: Number(wifiInfo.antenna),
elevation: Number(wifiInfo.elevation),
azimuth: Number(wifiInfo.azimuth),
mechanicalDownTilt: Number(wifiInfo.mechanical_down_tilt),
electricalDownTilt: Number(wifiInfo.electrical_down_tilt),
deprecatedMechanicalDownTilt: Number(wifiInfo.mechanical_down_tilt),
deprecatedElectricalDownTilt: Number(wifiInfo.electrical_down_tilt),
},
})
);
Expand Down Expand Up @@ -203,14 +203,16 @@ export async function run(args: any = process.argv) {
// decodedAcc.deploymentInfo?.wifiInfoV0?.azimuth ||
// acc.wifiInfo.deploymentInfo.azimuth ||
// 0,
mechanicalDownTilt:
decodedAcc.deploymentInfo?.wifiInfoV0?.mechanicalDownTilt || 0,
deprecatedMechanicalDownTilt:
decodedAcc.deploymentInfo?.wifiInfoV0
?.deprecatedMechanicalDownTilt || 0,
// mechanicalDownTilt descrepency was found and backfilled so default to whats on chain
// decodedAcc.deploymentInfo?.wifiInfoV0?.mechanicalDownTilt ||
// acc.wifiInfo.deploymentInfo.mechanicalDownTilt ||
// 0,
electricalDownTilt:
decodedAcc.deploymentInfo?.wifiInfoV0?.electricalDownTilt || 0,
deprecatedElectricalDownTilt:
decodedAcc.deploymentInfo?.wifiInfoV0
?.deprecatedElectricalDownTilt || 0,
// electricalDownTilt descrepency was found and backfilled so default to whats on chain
// decodedAcc.deploymentInfo?.wifiInfoV0?.electricalDownTilt ||
// acc.wifiInfo.deploymentInfo.electricalDownTilt ||
Expand Down
10 changes: 5 additions & 5 deletions programs/helium-entity-manager/src/state.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,12 +254,12 @@ pub enum MobileDeploymentInfoV0 {
antenna: u32,
// the height of the hotspot above ground level in whole meters
elevation: i32,
// integer representation of a 2-point precision decimal
// the azimuht of the hotspot in rounded number of degrees
azimuth: u16,
// integer representation of a 2-point precision decimal
mechanical_down_tilt: u16,
// integer representation of a 2-point precision decimal
electrical_down_tilt: u16,
// deprecated: integer representation of a 2-point precision decimal
_deprecated_mechanical_down_tilt: u16,
// deprecated: integer representation of a 2-point precision decimal
_deprecated_electrical_down_tilt: u16,
},
CbrsInfoV0 {
radio_infos: Vec<RadioInfoV0>,
Expand Down
4 changes: 2 additions & 2 deletions tests/helium-entity-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1012,8 +1012,8 @@ describe("helium-entity-manager", () => {
antenna: 1,
elevation: 2,
azimuth: 3,
mechanicalDownTilt: 4,
electricalDownTilt: 5,
deprecatedMechanicalDownTilt: 4,
deprecatedElectricalDownTilt: 5,
};

const method = (
Expand Down
Loading