refactor(parameters): back Parameters with BTreeMap#506
Merged
janimo merged 2 commits intohellas-ai:masterfrom Apr 28, 2026
Merged
refactor(parameters): back Parameters with BTreeMap#506janimo merged 2 commits intohellas-ai:masterfrom
janimo merged 2 commits intohellas-ai:masterfrom
Conversation
Switch the underlying map of abstract_interpreter::parameters::Parameters from HashMap to BTreeMap. Sorted iteration is now intrinsic to the type; downstream call sites no longer need explicit canonical_paths/sort_unstable to get a deterministic order. Required derives: - Path / PathComponent gain PartialOrd / Ord, since BTreeMap requires K: Ord. They were already Hash + Eq, so this is purely additive. Caller updates are mechanical — HashMap::new at construction sites becomes BTreeMap::new. No behaviour change beyond iteration order being deterministic by key.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch the underlying map of abstract_interpreter::parameters::Parameters from HashMap to BTreeMap. Sorted iteration is now intrinsic to the type; downstream call sites no longer need explicit canonical_paths/sort_unstable to get a deterministic order.
Required derives:
Caller updates are mechanical — HashMap::new at construction sites becomes BTreeMap::new. No behaviour change beyond iteration order being deterministic by key.