Fix WASM subsetter exports destructure, asset path, and add hardening/smoke test#23
Open
cto-new[bot] wants to merge 1 commit intodevelopfrom
Conversation
Fix root cause where WebAssembly.instantiate returns an object with an 'instance' property. Access instance.exports rather than assuming exports are top-level. Now reliably acquires HarfBuzz exports, preventing runtime errors and failed CI builds. - Resolve WASM asset path relative to module using import.meta.url and fileURLToPath, ensuring build stability regardless of cwd - Add defensive guards: verify required HarfBuzz exports (esp. memory) and throw descriptive errors if not present - Singleton WASM instantiation: create once per call, reuse in loop - Fix code style: tabs, lint, and skipLibCheck for clarity - Add smoke test to prevent regression on local/CI No user-visible breaking changes, but this restores functioning builds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes CI and local build failures caused by incorrect usage of WebAssembly.instantiate in the font subsetter, hardens WASM initialization to catch errors upfront, and adds a local smoke test for rapid regression feedback.
Details
Warning: Task VM test is not passing, cto.new will perform much better if you fix the setup