Skip to content

2.1.2 Sensor graph changes#1297

Open
zafrani wants to merge 2 commits intodevelopfrom
212/graph-gap
Open

2.1.2 Sensor graph changes#1297
zafrani wants to merge 2 commits intodevelopfrom
212/graph-gap

Conversation

@zafrani
Copy link
Contributor

@zafrani zafrani commented Apr 18, 2017

@jimmymlu you may want to use this as reference for iOS.


This PR does the following:

  1. Only draw 1/3 of the values returned from the server. In addition we check to see if a skipped point is equal to the max value in the graph. If so we draw that too so the user doesn't see it missing.
  2. If a graphs max - min value is less than 5 we reduce the min by 5. If the min can't be reduced we increase the max by 5. If the max was originally 0 we just set it to 1 instead of increasing by 5.
  3. Increased corner path radius for smoother looking graphs.

The following are images of the new graphs.

graph_new_temp
graph_new_noise
graph_new_light
graphs_new_1
graphs_new_2
graphs_new_3

@zafrani zafrani added the WIP label Apr 18, 2017
@simonc312
Copy link
Contributor

@zafrani so doing this will make it so that the graph will never touch the min value if min can be lowered or touch the max value if the max value can be increased?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants