Open
Conversation
simonc312
reviewed
Apr 25, 2017
|
|
||
| @UsedInTransition | ||
| private View rootView; | ||
| @UsedInTransition |
Contributor
There was a problem hiding this comment.
What does removing the fill view do? Does it affect the enter / exit animation for insight info?
Contributor
Author
There was a problem hiding this comment.
Removes an unused variable.
simonc312
suggested changes
Apr 26, 2017
Contributor
simonc312
left a comment
simonc312
left a comment
There was a problem hiding this comment.
@jimmymlu @spencerv this pr will cause existing insight animation to be non existent. I am against doing that just in order to return to home screen on back press.
What I think should happen is that the insights fragment intercepts the back pressed and finishes the insight info fragment itself to preserve the animation.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/Zdz62R8G/92-pressing-the-native-back-arrow-from-insights-detail-view-will-exit-the-app-instead-of-returning-to-home-screen