Conversation
zafrani
commented
Apr 25, 2017
| public void onUpdateAvailable(@NonNull Timeline timeline) { | ||
| if (getAdapterPosition() != RecyclerView.NO_POSITION) { | ||
| public void onUpdateAvailable(@NonNull final Timeline timeline) { | ||
| if (wantsUpdates()) { |
Contributor
Author
There was a problem hiding this comment.
This is what fixed it.
simonc312
reviewed
May 30, 2017
Contributor
simonc312
left a comment
simonc312
left a comment
There was a problem hiding this comment.
haven't run this build on a device yet, but there are only minor comments I have.
| throw new IllegalStateException("Activity must implement OnTimelineDateSelectedListener"); | ||
| } | ||
| this.listener = ((OnTimelineDateSelectedListener) getActivity()); | ||
| this.zoomedOutTimelineInteractor.setFirstDate(DateFormatter.lastNight()); |
Contributor
There was a problem hiding this comment.
instead of saving timeline and start date of first timeline through arguments here it was moved that to onViewCreated
| this.zoomedOutTimelineInteractor.cacheTimeline(startDate, firstTimeline); | ||
| } | ||
| } | ||
| this.presenterView.setMonthText(this.dateFormatter.formatAsTimelineNavigatorDate(startDate)); |
Contributor
There was a problem hiding this comment.
can make use of the getFormattedDate( LocalDate localDate) method here
| } | ||
|
|
||
| @Override | ||
| public void retrieveTimelines() { |
Contributor
There was a problem hiding this comment.
small nitPick can this just be standardized as getTimelines() ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/ONXgjJ2Z/109-zoomed-out-timeline-sleep-scores-will-change-when-swiping-through-the-list-and-returning-to-the-beginning