Skip to content

Replace HardwarePresenter with the new SenseService in CommonSense#386

Closed
decarbonization wants to merge 23 commits intodevelopfrom
km/use-sense-service
Closed

Replace HardwarePresenter with the new SenseService in CommonSense#386
decarbonization wants to merge 23 commits intodevelopfrom
km/use-sense-service

Conversation

@decarbonization
Copy link
Contributor

Depends on hello/android-commonsense#12.


Cards:


Changes include...

  • Completely removed the monolithic HardwarePresenter state machine
  • Isolated Sense discovery into new SensePresenter class that properly handles app hibernation
  • Added in-app alert for system-level pairing requests to prevent some errors
  • Switched to SenseService and SenseServiceConnection for all peripheral communication

@jimmymlu
Copy link
Contributor

jimmymlu commented Mar 9, 2016

⚠️ only merge this when develop is clean. After review, which requires a lot of testing, merge only after develop is clean and 1.3.0 is on it's way out

@jimmymlu
Copy link
Contributor

⚠️ ok, let's not merge this in until 1.4.0. This is quite a big change that needs to be well tested. 1.3.1 is aiming to fix lower priority Trends bugs so we don't want to include this huge change in. Moving the task for this to Trello for 1.4.0

@simonc312
Copy link
Contributor

Is this branch just going to stay frozen for now?

@jimmymlu
Copy link
Contributor

jimmymlu commented Jun 1, 2016

yes. let's close this PR and keep the branch. closing now

@jimmymlu jimmymlu closed this Jun 1, 2016
@zafrani zafrani deleted the km/use-sense-service branch January 9, 2017 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants