Unify questions and insights into single endpoint#3
Open
decarbonization wants to merge 2 commits intomasterfrom
Open
Unify questions and insights into single endpoint#3decarbonization wants to merge 2 commits intomasterfrom
decarbonization wants to merge 2 commits intomasterfrom
Conversation
Contributor
Author
There was a problem hiding this comment.
I am not sure this is the best way to do grouping. We might want to restrict an AttachmentCollection to a single type to make processing easier, but this could also be used to represent question / graph / insight compound cards, which could be a good thing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since shipping
1.0.0, the client has displayed questions and insights in a single view. Assuming this continues to be true for the foreseeable future, it makes a lot of sense to merge these two endpoints into one from the client's perspective.To achieve this, I've specced an endpoint that returns a collection of polymorphic attachment objects. This allows us to present multiple related data types, and potentially collect user feedback in direct response to information displayed.
In addition to this, I've also specced out a basic last viewed / unread count mechanism to allow the clients to cheaply display unread indicators when the insights view is not visible.